Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] pos_payment_method_cashdro #1208

Open
wants to merge 14 commits into
base: 17.0
Choose a base branch
from

Conversation

sbejaoui
Copy link

No description provided.

chienandalu and others added 13 commits June 24, 2024 16:28
This module allows to make payments with a Cashdro (https://www.cashdro.com) terminal
on the Point of Sale frontend.

TT29224
Currently translated at 100.0% (8 of 8 strings)

Translation: pos-14.0/pos-14.0-pos_payment_method_cashdro
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_payment_method_cashdro/it/
Overcome floting point issues: https://stackoverflow.com/a/588014

For expample 2.3 * 100 ->  229.99999999999997

TT42574
Currently translated at 100.0% (8 of 8 strings)

Translation: pos-14.0/pos-14.0-pos_payment_method_cashdro
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_payment_method_cashdro/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-16.0/pos-16.0-pos_payment_method_cashdro
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_method_cashdro/
Currently translated at 100.0% (6 of 6 strings)

Translation: pos-16.0/pos-16.0-pos_payment_method_cashdro
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_method_cashdro/it/
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbejaoui !

Do you know why the tests are failing? Is it failing because of something overriden in this module?

@pedrobaeza
Copy link
Member

/ocabot migration pos_payment_method_cashdro

@sbejaoui
Copy link
Author

Thanks @sbejaoui !

Do you know why the tests are failing? Is it failing because of something overriden in this module?

The failing test is in the pos_lot_barcode module

@sbejaoui sbejaoui force-pushed the 17.0-pos_payment_method_cashdro-sbj branch from f70597c to b668362 Compare June 25, 2024 09:24
@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 25, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 25, 2024
30 tasks
@chaule97
Copy link

The failing test is in the pos_lot_barcode module

Hi @sbejaoui , I have a problem same as you, do you know the reason?

@OCA-git-bot
Copy link
Contributor

Sorry @sbejaoui you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@sbejaoui
Copy link
Author

The failing test is in the pos_lot_barcode module

Hi @sbejaoui , I have a problem same as you, do you know the reason?

I have no idea right now, but I’m willing to debug this soon. I’ll let you know

@chaule97
Copy link

I have no idea right now, but I’m willing to debug this soon. I’ll let you know

Thanks, I just realized that when the test case runs self.start_tour(...), it waits for the JavaScript tour to execute, but the tour JavaScript file is not compiled in time and time out error

@chienandalu
Copy link
Member

In the PR tests logs it shows a failing step, not a timeout, that might be related with this module migration:

----- FAILING STEP -----
{
  "content": "now in payment screen",
  "trigger": ".pos-content .payment-screen",
  "run": "[function]"
},
-----------------------

You can try a temporal commit disable pos_payment_method_cashdro installation to check if then the tests passes. If so, there's some intereaction between them both. If not, then is that other module only fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants