[16.0] [MIG] pos_event_sale: Migration to 16.0 #1205
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivantodorovich , continue the pr of @BT-dmoreno (#1022) Here. |
maq-adhoc
force-pushed
the
16.0-t-40124-maq
branch
3 times, most recently
from
e9d3004
to
28ec285
Compare
maq-adhoc
changed the title
|
Thanks @maq-adhoc ! CI is still broken, though. |
|
@ivantodorovich , this week I want to leave all the tests ok. When it's ready I'll let you know |
|
/ocabot migration pos_event_sale |
|
The migration issue (#849) has not been updated to reference the current pull request because a previous pull request (#1022) is not closed. |
maq-adhoc
force-pushed
the
16.0-t-40124-maq
branch
2 times, most recently
from
2325ccf
to
de173b9
Compare
maq-adhoc
force-pushed
the
16.0-t-40124-maq
branch
2 times, most recently
from
c1b3a42
to
880624e
Compare
By default, the longPressDelay is 1000ms which is not intuitive and makes it pretty much unusable in touchscreen devices. In this case, it makes no sense to have a delay for selecting dates. By setting it to 0 we're effectively disabling the pressDelay, and the user experience is much better.
* Print event.registration receipts. * Refunding a pos.order will cancel the event registrations. * Support pricelists. * Refactored code for better overrideability.
This allows to play nice with other modules, that may either be: * Trying to modify the created registrations * Creating registrations themselves * Or even calling `_create_event_registrations` programatically. It has no impact on functionality, though.
There was a typo on the xml view, having it not rendering properly.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-15.0/pos-15.0-pos_event_sale Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/
When paying a `pos.order`, confirm only the `event.registration` that are in draft state. Don't attempt to confirm the ones that are already confirmed, nor the ones that might be cancelled.
If we cancel a `pos.order`, we should cancel the related `event.registration`(s) However, if the `event.registration` is already done, we should not cancel it as it would be already too late to do so.
Registrations created from the PoS are not to be confirmed automatically. We confirm them when the `pos.order` is paid, but they are to remain in `draft` until then.
In the PoS, if the order is not paid, then it's not confirmed. If it's not confirmed, then we might as well ignore it. We shouldn't cancel any existing registrations until then.
Negated lines are particularly useful with PoS modules that disable the removal of pos orderlines through the use of ``disallowLineQuantityChange``. This is the case of `l10n_fr_pos_cert` module, for example. But there are other core modules doing it, too. In this case, added order lines can't be removed. Instead, the cashier is encouraged to add a negative to 'cancel' the original one. e.g.: Adds a line with 10 tickets. Then, adds a line with -10 tickets. This should be almost the same as removing the first line: no actual registration should be confirmed in the end, as we're reverting this sale.
Moved some ORM tests to `tests_backend`, that will execute faster than tours. Added unit tests to cover more backend scenarios.
EventEventTicket inherits from EventTypeTicket, so we don't need to duplicate the field declaration, if it is the same in both module. This ease overriding, as we need to override only one model, if we expect the same behavior in both.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-15.0/pos-15.0-pos_event_sale Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/
Currently translated at 100.0% (73 of 73 strings) Translation: pos-15.0/pos-15.0-pos_event_sale Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/it/
maq-adhoc
force-pushed
the
16.0-t-40124-maq
branch
from
880624e
to
7e8997b
Compare
maq-adhoc
force-pushed
the
16.0-t-40124-maq
branch
from
7e8997b
to
d6a1b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.