[16.0][ADD] crm_exception #527

AungKoKoLin1997 · 2023-11-13T08:36:01Z

This module allows you to attach several customizable exceptions to your opportunities.
@qrtl

rinaldifirdaus

Functional Test: Works as expected.

yostashiro · 2023-11-25T08:46:19Z

crm_exception/readme/USAGE.rst

Please use CONFIGURE.md instead.

yostashiro · 2023-11-25T09:09:22Z

crm_exception/models/crm_lead.py

+    @api.constrains("ignore_exception", "stage_id")
+    def _check_quantity_positive(self):
+        for record in self:
+            record._check_exception()


We should actually extend the write() method to ensure that the check is not restricted to certain fields. For example, with the current logic, even if a field is made required for a specific stage by an exception rule, the field value can be removed once the opportunity is saved with that stage.

yostashiro · 2023-11-25T09:12:14Z

crm_exception/views/base_exception_views.xml

+                    name="stage_ids"
+                    widget="many2many_tags"
+                    attrs="{'invisible': [('model', '!=', 'crm.lead')]}"
+                    groups="base.group_system"


Why assign this group here?

I want to use model field in attrs and this field can be accessed by base.group_system.
https://github.com/OCA/server-tools/blob/97be5cf17cc32f4ef3e21fa493868426a5054b2d/base_exception/views/base_exception_view.xml#L44-L45

@AungKoKoLin1997 We shouldn't need this, then, since the parent node already has the group.

yostashiro · 2023-11-25T09:20:26Z

@AungKoKoLin1997 Please add tests as well.

yostashiro · 2023-11-29T09:34:38Z

crm_exception/models/crm_lead.py

+        base_rule_domain = super()._rule_domain()
+        if self.stage_id:
+            rule_domain = expression.AND(
+                [
+                    base_rule_domain,
+                    [
+                        "|",
+                        ("stage_ids", "in", tuple(self.stage_id.ids)),
+                        ("stage_ids", "=", False),
+                    ],
+                ]
+            )
+            return rule_domain
+        return base_rule_domain


Suggested change

base_rule_domain = super()._rule_domain()

if self.stage_id:

rule_domain = expression.AND(

[

base_rule_domain,

[

"|",

("stage_ids", "in", tuple(self.stage_id.ids)),

("stage_ids", "=", False),

],

]

)

return rule_domain

return base_rule_domain

rule_domain = super()._rule_domain()

if self.stage_id:

rule_domain = expression.AND(

[

rule_domain,

[

"|",

("stage_ids", "in", self.stage_id.ids),

("stage_ids", "=", False),

],

]

)

return rule_domain

Any reason to use tuple here? tuple(self.stage_id.ids)

If we don't convert to tuple in here, cache lookeup error(TypeError: unhashable type: 'list') will occur from this.
https://github.com/OCA/server-tools/blob/590cf43c30698fc8dd2fca306fe5bb6444ecb903/base_exception/models/exception_rule.py#L81

yostashiro · 2023-11-29T09:43:25Z

crm_exception/data/crm_exception_data.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo noupdate="1">
+    <record id="crm_excep_no_partner" model="exception.rule">


Shouldn't this be created as demo data?

yostashiro · 2023-11-29T09:48:24Z

crm_exception/tests/test_crm_exception.py

+        self.opportunity.stage_id = self.stage_qualified.id
+        self.assertEqual(self.opportunity.stage_id, self.stage_qualified)
+        self.opportunity.stage_id = self.stage_proposition.id
+        self.assertEqual(self.opportunity.stage_id, self.stage_proposition)
+        self.opportunity.stage_id = self.stage_won.id
+        self.assertEqual(self.opportunity.stage_id, self.stage_won)


Suggested change

self.opportunity.stage_id = self.stage_qualified.id

self.assertEqual(self.opportunity.stage_id, self.stage_qualified)

self.opportunity.stage_id = self.stage_proposition.id

self.assertEqual(self.opportunity.stage_id, self.stage_proposition)

self.opportunity.stage_id = self.stage_won.id

self.assertEqual(self.opportunity.stage_id, self.stage_won)

self.opportunity.stage_id = self.stage_qualified.id

self.opportunity.stage_id = self.stage_proposition.id

self.opportunity.stage_id = self.stage_won.id

yostashiro · 2023-11-29T09:49:50Z

crm_exception/tests/test_crm_exception.py

+        self.opportunity.stage_id = self.stage_won.id
+        self.assertEqual(self.opportunity.stage_id, self.stage_won)
+
+        # Check exception only for qualified and won stages


Split the following into a separate test.

yostashiro · 2023-11-29T10:11:18Z

@AungKoKoLin1997 Please add an explanation on the limitation on extending the create method.

yostashiro

Code review.

OCA-git-bot · 2023-11-30T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AungKoKoLin1997 · 2024-01-05T06:45:05Z

@oca-crm-maintainers
Is it possible to take a look this PR?

github-actions · 2024-05-05T12:28:54Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

AungKoKoLin1997 · 2024-06-27T04:19:34Z

Tests fails are not related with this PR.

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch from 5576ca2 to 76344ab Compare November 16, 2023 08:18

AungKoKoLin1997 mentioned this pull request Nov 16, 2023

[16.0][IMP] base_exception: add mixin model OCA/server-tools#2757

Closed

peluko00 mentioned this pull request Nov 16, 2023

Migration to version 17.0 #525

Open

19 tasks

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch 4 times, most recently from cdc6f1a to 9f86c0e Compare November 21, 2023 07:27

rinaldifirdaus approved these changes Nov 22, 2023

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch from 9f86c0e to 5e766ce Compare November 24, 2023 01:36

yostashiro suggested changes Nov 25, 2023

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch 5 times, most recently from 92da9fb to 359c128 Compare November 29, 2023 05:18

yostashiro suggested changes Nov 29, 2023

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch 2 times, most recently from 3c52cd4 to a9da33c Compare November 30, 2023 09:49

yostashiro approved these changes Nov 30, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 30, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch from a9da33c to 53e3486 Compare May 7, 2024 03:22

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch from 53e3486 to 7ce4276 Compare June 27, 2024 02:43

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch 3 times, most recently from 99b72e4 to 684b856 Compare June 27, 2024 04:12

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch from 684b856 to 7870f71 Compare July 8, 2024 03:00

[ADD] crm_exception

b9ff0a4

AungKoKoLin1997 force-pushed the 16.0-add-crm_exception branch from 7870f71 to b9ff0a4 Compare August 19, 2024 03:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] crm_exception #527

[16.0][ADD] crm_exception #527

AungKoKoLin1997 commented Nov 13, 2023 •

edited

Loading

rinaldifirdaus left a comment

yostashiro Nov 25, 2023

yostashiro Nov 25, 2023

yostashiro Nov 25, 2023

AungKoKoLin1997 Nov 25, 2023

yostashiro Nov 25, 2023

yostashiro commented Nov 25, 2023

yostashiro Nov 29, 2023

AungKoKoLin1997 Nov 30, 2023 •

edited

Loading

yostashiro Nov 29, 2023

yostashiro Nov 29, 2023

yostashiro Nov 29, 2023

yostashiro commented Nov 29, 2023

yostashiro left a comment

OCA-git-bot commented Nov 30, 2023

AungKoKoLin1997 commented Jan 5, 2024

github-actions bot commented May 5, 2024

AungKoKoLin1997 commented Jun 27, 2024

[16.0][ADD] crm_exception #527

Are you sure you want to change the base?

[16.0][ADD] crm_exception #527

Conversation

AungKoKoLin1997 commented Nov 13, 2023 • edited Loading

rinaldifirdaus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yostashiro commented Nov 25, 2023

Choose a reason for hiding this comment

AungKoKoLin1997 Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yostashiro commented Nov 29, 2023

yostashiro left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 30, 2023

AungKoKoLin1997 commented Jan 5, 2024

github-actions bot commented May 5, 2024

AungKoKoLin1997 commented Jun 27, 2024

AungKoKoLin1997 commented Nov 13, 2023 •

edited

Loading

AungKoKoLin1997 Nov 30, 2023 •

edited

Loading