Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add publish.yml #270

Closed
wants to merge 1 commit into from
Closed

CI: Add publish.yml #270

wants to merge 1 commit into from

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Apr 26, 2024

This would make publishing new crate easier, without having to use commandline.

Just create a release on GitHub and it would automatically publishes to the crates.io

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu requested a review from robjtede April 26, 2024 07:01
@NobodyXu
Copy link
Collaborator Author

@robjtede If you are good with this PR, then I will add the crates.io token for publishing new versions of this crate to secrets, and then merge it.

@robjtede
Copy link
Member

We're on the right track here. I've used release-plz for some other things and I think that we should use that instead. It's a bit more of a robust approach.

@NobodyXu
Copy link
Collaborator Author

I happen to need release-plz in my other project, so if I successfully implement it, I would also adopt it here.

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented May 3, 2024

Ok I figured it out, it's pretty simple though my other project can't use it for now.

Would open another PR soon

@NobodyXu NobodyXu closed this May 3, 2024
@NobodyXu NobodyXu deleted the ci/publish branch May 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants