Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Stop supporting console.log selectors with "(u)int" aliases #5764

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat!: Stop supporting console.log selectors with "(u)int" aliases #5764

wants to merge 3 commits into from

Commits on Sep 19, 2024

  1. feat!: Stop supporting console.log selectors with "(u)int" aliases 

    Historically, Hardhat used selectors that computed signatures such as
"log(int)", "log(bool,int)", even though the canonical ABI spec defines
that the keccak256 should be calculated over the canonical type name, so
"int256" or "uint256".

This change removes this support as popular tools already support the
correct ABI encoding or patch the faulty one, instead.
    @Xanewok
    Xanewok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3df95d3 View commit details
    Browse the repository at this point in the history

  2. refactor: Simplify CONSOLE_LOG_SIGNATURES construction

    @Xanewok
    Xanewok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c62f044 View commit details
    Browse the repository at this point in the history

  3. test: Drop the console.log backward-compatibility test

    @Xanewok
    Xanewok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    82d0c84 View commit details
    Browse the repository at this point in the history