Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viem 2 on ethereumjs main #4912

Closed
wants to merge 4 commits into from
Closed

Conversation

kanej
Copy link
Member

@kanej kanej commented Feb 21, 2024

A PR to recreate the viem@2 changes on ethereumjs/main.

Copy link

changeset-bot bot commented Feb 21, 2024

⚠️ No Changeset found

Latest commit: 6ed3654

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 10:05pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 21, 2024
@@ -1,6 +1,6 @@
{
"name": "@nomicfoundation/hardhat-viem",
"version": "1.0.4",
"version": "2.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as long as it is for testing, but shouldn't be merged with the version bump, as changeset should take care of that.

Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but remember to revert the hardhat-viem version bump.

@kanej
Copy link
Member Author

kanej commented Feb 22, 2024

Looks good but remember to revert the hardhat-viem version bump.

This is being merged into ethereumjs/main with the intent of recreating the equivalent of the commits that have updated hardhat-viem on main.

On main the version of hardhat-viem is 2.0.0:

"version": "2.0.0",

On ethereumjs/main it is 1.0.4:

"version": "1.0.4",

Merging this will update ethereumjs/main to the same, without re-releasing. We will only use changeset for future releases, here we use the commit that changset created to recreate the effect i.e. 6ed3654

@kanej kanej marked this pull request as ready for review February 23, 2024 10:15
@kanej
Copy link
Member Author

kanej commented Mar 8, 2024

This PR is no longer needed as Toolbox will ship based on main rather than ethereumjs/main.

@kanej kanej closed this Mar 8, 2024
@kanej kanej deleted the viem-2-on-ethereumjs-main branch May 9, 2024 19:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants