You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using ~5.0.0 as the version range in all packages (even the toolbox).
This commit is the one that fixes the two compilation errors that showed up after upgrading.
I added a workflow to compile the whole repository with typescript v4. I also pushed a temporary commit to double-check that the workflow fails as expected (see here).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I think the workflow is overly restrictive. I believe that what we want is to check is that Hardhat's generated .d.ts are still compatible with TS 4.x, that's not the same as the sources being compatible.
@alcuadrado that makes sense, but since it's passing, do you mind if we merge it? I think testing this properly would require e2e tests. I can update the e2e issue to include that, and we can remove that workflow when we do it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fvictorio
force-pushed
the
upgrade-to-ts-5
branch
from
We'll need this to be able to use viem.
@alcuadrado important things here:
~5.0.0as the version range in all packages (even the toolbox).