glslang: build shared libraries #342459
Open
glslang: build shared libraries #342459
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bot-wxt1221
reviewed
Sep 19, 2024
bobby3605
changed the title
Ralith
approved these changes
Sep 19, 2024
|
Should we backport it? |
Bot-wxt1221
added
backport release-24.05
|
Note the commit message still hasn't been corrected. |
shared libraries are required for some of the c++ api classes such as TShader
bobby3605
force-pushed
the
glslang-shared
branch
from
1d77070
to
c3948c2
Compare
|
I've updated the commit message. |
|
I've been unable to get a full nixpkgs-review pr test because python3.10-websockets-12.0 gets stuck on Executing unittestCheckPhase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Build shared glslang libraries.
For reference, view the arch pkgbuild, which correctly builds the shared libraries.
I ran into linker errors with my application, which depends on glslang, and the lack of shared libraries was the culprit.
Things done
Added -DBUILD_SHARED_LIBS=ON to cmakeFlags.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.