Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musescore: 4.3.2 -> 4.4.0 #337764

Merged
merged 1 commit into from
Sep 5, 2024
Merged

musescore: 4.3.2 -> 4.4.0 #337764

merged 1 commit into from
Sep 5, 2024

Conversation

doronbehar
Copy link
Contributor

Description of changes

Not ready yet, see musescore/MuseScore#24235 .

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ThePuzzlemaker
Copy link
Contributor

ThePuzzlemaker commented Sep 1, 2024

A few other things are broken in my testing:

Thanks for your work, the rest looks good!

@doronbehar doronbehar marked this pull request as ready for review September 4, 2024 20:31
@doronbehar
Copy link
Contributor Author

Thanks @ThePuzzlemaker for the links and the comment, and sorry it took me a while to get back to this. I added that upstream open patch to the PR, and I didn't experience the GLib-GIO-ERROR error you experienced - it is a common issue on systems without classic desktop environments. I also suspect it was an issue with musescore 4.3.2 (could you check?). If indeed that is the case, I won't try to solve that during the update.

@doronbehar
Copy link
Contributor Author

I also tested that the musescore.passthru.tests build. Merging.

@doronbehar doronbehar merged commit 93674b2 into NixOS:master Sep 5, 2024
24 of 26 checks passed
@doronbehar doronbehar deleted the pkg/musescore branch September 5, 2024 08:24
@azuwis azuwis mentioned this pull request Sep 6, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants