Transient interface for Nix flake commands #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me so far! |
Show flake:* names as well for convenience in completing registry entries.
- Add docstrings and autoloads. - Follow the naming conventions of readers. - Avoid use of colons in symbol names
According to the guideline, *arguments* refer to required arguments, which is either a flake ref or installable for most commands. *Options* refer to both boolean flags and other optional arguments starting with hyphen. It is better to stick with the terminology. Also, options are appended to the command line after the required arguments, so follow the rule as well. For details, see https://nixos.org/manual/nix/stable/contributing/cli-guideline.html
akirak
force-pushed
the
flake-transient
branch
from
968cdb3
to
ef2efae
Compare
|
I squashed commits and added transient to the dependency list in flake.nix.
|
|
You need to bump to 14.v1 to fix the CI error |
Based on the comment by Domen Kožar (@domenkozar) at NixOS#140 (comment) Co-authored-by: Domen Kožar <[email protected]>
|
@domenkozar Thank you. It's working! |
matthewbauer
pushed a commit
that referenced
this pull request
Nov 9, 2021
Based on the comment by Domen Kožar (@domenkozar) at #140 (comment) Co-authored-by: Domen Kožar <[email protected]> (cherry picked from commit 2a24b40)
|
Thank you so much for merging this PR! |
This was referenced Nov 20, 2021
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to implement #104.
I don't know if you will like this, but it has helped me with building flakes, so I will propose a draft PR.