Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.8; updating annotation typing #508

Merged
merged 10 commits into from
Sep 16, 2024
Merged

Remove 3.8; updating annotation typing #508

merged 10 commits into from
Sep 16, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

Pre-PR to #507

Removes 3.8 and updates the relevant typing to 3.9+ standard (using built-in references instead of typing module classes)

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 6, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 6, 2024 17:51
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Updated a couple extra files

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) September 16, 2024 17:56
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.97%. Comparing base (c7861f4) to head (e459c16).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/nwbinspector/_dandi_inspection.py 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #508      +/-   ##
==========================================
+ Coverage   79.53%   84.97%   +5.44%     
==========================================
  Files          48       48              
  Lines        1412     1411       -1     
==========================================
+ Hits         1123     1199      +76     
+ Misses        289      212      -77     
Files with missing lines Coverage Δ
src/nwbinspector/_configuration.py 96.22% <100.00%> (ø)
src/nwbinspector/_formatting.py 85.40% <100.00%> (ø)
src/nwbinspector/_nwb_inspection.py 83.82% <100.00%> (+4.41%) ⬆️
src/nwbinspector/_organization.py 100.00% <100.00%> (ø)
src/nwbinspector/testing/_testing.py 83.63% <100.00%> (+1.81%) ⬆️
src/nwbinspector/tools/_dandi.py 20.68% <100.00%> (ø)
src/nwbinspector/utils/_utils.py 91.89% <100.00%> (ø)
src/nwbinspector/_dandi_inspection.py 98.03% <90.00%> (+76.88%) ⬆️

... and 2 files with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit 4856bd6 into dev Sep 16, 2024
38 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the remove_3_8 branch September 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants