Final deprecation of insect_nwb
#505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephprince
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Really making use of the 'or after' clause on this one
Better late than never! Looks good - I found a couple of other locations that reference inspect_nwb that I think need to be updated as well:
docs/user_guide/using_the_library.rstdocs/user_guide/using_the_library_advanced.rstsrc/nwbinspector/nwbinspector/__init__.py
|
@stephprince Sharp eye! When you add documentation tests, it might be nice to make them 'nitpicky' (throw error on warning, such as deprecations) to automatically catch such things Removed those items |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #505 +/- ##
==========================================
+ Coverage 79.33% 84.91% +5.57%
==========================================
Files 48 48
Lines 1423 1419 -4
==========================================
+ Hits 1129 1205 +76
+ Misses 294 214 -80
|
stephprince
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really making use of the 'or after' clause on this one