Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import #494

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Fix import #494

merged 2 commits into from
Aug 31, 2024

Conversation

bendichter
Copy link
Contributor

Motivation

fix #493

@bendichter
Copy link
Contributor Author

@CodyCBakerPhD , do we have a test for the actual CLI calls that might catch this sort of thing?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (383e880) to head (a1c2e5f).

Files with missing lines Patch % Lines
src/nwbinspector/_inspection_cli.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #494      +/-   ##
==========================================
+ Coverage   81.99%   82.21%   +0.21%     
==========================================
  Files          47       47              
  Lines        1366     1366              
==========================================
+ Hits         1120     1123       +3     
+ Misses        246      243       -3     
Flag Coverage Δ
unittests 82.21% <66.66%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/nwbinspector/_inspection_cli.py 81.35% <66.66%> (ø)

... and 1 file with indirect coverage changes

@CodyCBakerPhD
Copy link
Collaborator

Dang, we were reliant on the testing suite to test exactly this kind of issue but somehow over all these years there never was a --config dandi test

Added in #495, which should fail on main as proof that it could catch something like this, and will pass once this is through

Refactoring the tests is on the list of things to do over the next month, so we'll be sure to take another look from top to bottom for any more holes like this

@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Aug 31, 2024
@CodyCBakerPhD CodyCBakerPhD merged commit fb4e389 into dev Aug 31, 2024
34 of 37 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix-import branch August 31, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CLI with config not working
3 participants