Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bug in nwbToTable (Issue #597 ) #598

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Sep 17, 2024

Fix #597

Motivation

fix bug

How to test the behavior?

See issue

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.59%. Comparing base (c51099f) to head (79e76a1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   90.60%   90.59%   -0.01%     
==========================================
  Files         106      106              
  Lines        4671     4670       -1     
==========================================
- Hits         4232     4231       -1     
  Misses        439      439              
Flag Coverage Δ
90.59% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter
Copy link
Contributor

Can you please add a test that fails before and passes now?

Add test that passes with this fix but would have filed before
Fix bug in nwbToTable, should not have deleted elements of array using for loop indices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: toTable method does not work if a DynamicTableRegion is added as a last column of a table
2 participants