spotbugs 4.8.1 (#1094)

Update to latest version of spotbugs and gradle plugin to avoid build errors when using jdk21.
Netflix · Nov 15, 2023 · 2631305 · 2631305
1 parent 92e7033
commit 2631305
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/build.gradle b/build.gradle
@@ -1,6 +1,6 @@
 plugins {
   id 'com.github.ben-manes.versions' version '0.47.0'
-  id 'com.github.spotbugs' version '5.1.3' apply false
+  id 'com.github.spotbugs' version '5.2.3' apply false
   id 'me.champeau.jmh' version '0.7.1'
   id 'com.netflix.nebula.dependency-recommender' version '12.2.0'
   id 'com.netflix.nebula.netflixoss' version '11.3.2'
@@ -107,7 +107,7 @@ subprojects {
   }
 
   spotbugs {
-    toolVersion = '4.7.3'
+    toolVersion = '4.8.1'
     excludeFilter = rootProject.file('codequality/findbugs-exclude.xml')
     ignoreFailures = false
     spotbugsMain.enabled = true

diff --git a/codequality/findbugs-exclude.xml b/codequality/findbugs-exclude.xml
@@ -54,6 +54,18 @@
       <Bug pattern="UL_UNRELEASED_LOCK"/>
     </And>
   </Match>
+  <Match>
+    <And>
+      <Class name="com.netflix.spectator.ipc.http.HttpUtils$GzipLevelOutputStream"/>
+      <Bug pattern="CT_CONSTRUCTOR_THROW"/>
+    </And>
+  </Match>
+  <Match>
+    <And>
+      <Class name="com.netflix.spectator.sandbox.HttpUtils$GzipLevelOutputStream"/>
+      <Bug pattern="CT_CONSTRUCTOR_THROW"/>
+    </And>
+  </Match>
   <Match>
     <And>
       <Class name="com.netflix.spectator.perf.ManyTags"/>

diff --git a/spectator-ext-spark/src/main/java/com/netflix/spectator/spark/SparkSink.java b/spectator-ext-spark/src/main/java/com/netflix/spectator/spark/SparkSink.java
@@ -27,7 +27,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.net.MalformedURLException;
 import java.util.Locale;
 import java.util.Properties;
 import java.util.concurrent.TimeUnit;
@@ -56,7 +55,7 @@ public class SparkSink implements Sink {
   public SparkSink(
       Properties properties,
       MetricRegistry registry,
-      org.apache.spark.SecurityManager manager) throws MalformedURLException {
+      org.apache.spark.SecurityManager manager) {
     final Config config = loadConfig();
     sidecarRegistry = new SidecarRegistry(
         Clock.SYSTEM, new SpectatorConfig(config.getConfig("spectator.spark.sidecar")));