Kaw 7904 header #26
Merged
Kaw 7904 header #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomaszDziezykNetcentric
requested review from
IoanaOrca and
lakshmishriaswathnarayana
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Hover color in the designs is darker red, are we keeping the lighter one?
I see in the design it's mentioned that the flyout is closing when the user is clicking on the darker part. Are we also adding that feature?
In the screenshot you can see the flyout staying open when it's not closed, i assume we add that later.
And one last thing. I see int he designs that there is an image animation on hover. Do we have an example of content for that?
|
IoanaOrca
reviewed
Sep 12, 2024
| @@ -94,6 +94,36 @@ function swappingPlacesBlock(main) { | |||
| }); | |||
| } | |||
|
|
|||
| export function customDecoreateIcons(main) { | |||
IoanaOrca
reviewed
Sep 12, 2024
blocks/header/header.js
Outdated
| import { loadFragment } from '../fragment/fragment.js'; | ||
|
|
||
| // media query match that indicates mobile/tablet width | ||
| const isDesktop = window.matchMedia('(min-width: 992px)'); | ||
| const isDesktop = window.matchMedia('(min-width: 1024px)'); |
There was a problem hiding this comment.
i think this is 1025 as per https://ncchat.slack.com/archives/C07KG702WMC/p1726052767589049
|
Yes like @IoanaOrca mentioned, when the nav bar below is opened, the bikes should have some animation. Can you align with michael tomorrow ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #KAW-7904
Test URLs: