A few more minor improvements

test-app/runtime/src/main/cpp/MetadataNode.cpp

@@ -671,9 +671,9 @@ vector<MetadataNode::MethodCallbackData *> MetadataNode::SetInstanceMethodsFromS
 
 MetadataNode::MethodCallbackData *MetadataNode::tryGetExtensionMethodCallbackData(
         std::unordered_map<std::string, MethodCallbackData *> collectedMethodCallbackDatas,
-        std::string lookupName) {
+        const std::string& lookupName) {
 
-    if (collectedMethodCallbackDatas.size() < 1) {
+    if (collectedMethodCallbackDatas.empty()) {
         return nullptr;
     }
 
@@ -1053,7 +1053,6 @@ Local<FunctionTemplate> MetadataNode::GetConstructorFunctionTemplate(Isolate* is
     // insert isolate-specific persistent function handle
     node->m_poCtorCachePerIsolate.insert({isolate, new Persistent<Function>(isolate, wrappedCtorFunc)});
     if (!baseCtorFunc.IsEmpty()) {
-        auto context = isolate->GetCurrentContext();
         wrappedCtorFunc->SetPrototype(context, baseCtorFunc);
     }
 
@@ -2039,7 +2038,7 @@ void MetadataNode::EnableProfiler(bool enableProfiler) {
     s_profilerEnabled = enableProfiler;
 }
 
-bool MetadataNode::IsJavascriptKeyword(std::string word) {
+bool MetadataNode::IsJavascriptKeyword(const std::string& word) {
     static set<string> keywords{
         "abstract", "arguments", "boolean", "break", "byte", "case", "catch", "char", "class", "const", "continue", "debugger", "default", "delete", "do",
         "double", "else", "enum", "eval", "export", "extends", "false", "final", "finally", "float", "for", "function", "goto", "if", "implements",

test-app/runtime/src/main/cpp/MetadataNode.h

@@ -74,7 +74,7 @@ class MetadataNode {
 
         MetadataNode(MetadataTreeNode* treeNode);
 
-        static bool IsJavascriptKeyword(std::string word);
+        static bool IsJavascriptKeyword(const std::string& word);
         v8::Local<v8::Object> CreatePackageObject(v8::Isolate* isolate);
 
         v8::Local<v8::Function> GetConstructorFunction(v8::Isolate* isolate);
@@ -97,7 +97,7 @@ class MetadataNode {
                 MetadataTreeNode* treeNode);
         static MethodCallbackData* tryGetExtensionMethodCallbackData(
                 std::unordered_map<std::string, MethodCallbackData*> collectedMethodCallbackDatas,
-                std::string lookupName);
+                const std::string& lookupName);
         void SetInstanceFieldsFromStaticMetadata(
                 v8::Isolate* isolate, PrototypeTemplateFiller& protoFiller,
                 MetadataTreeNode* treeNode);

test-app/runtime/src/main/cpp/ObjectManager.cpp

@@ -287,10 +287,6 @@ Local<Object> ObjectManager::GetEmptyObject(Isolate *isolate) {
     return m_wrapperObjectTemplate.Get(isolate)->NewInstance(context).ToLocalChecked();
 }
 
-void ObjectManager::JSWrapperConstructorCallback(const v8::FunctionCallbackInfo<v8::Value> &info) {
-    assert(info.IsConstructCall());
-}
-
 void ObjectManager::ReleaseNativeCounterpart(v8::Local<v8::Object> &object) {
 
     if(!object->IsObject()){

test-app/runtime/src/main/cpp/ObjectManager.h

@@ -80,8 +80,6 @@ class ObjectManager {
 
         static void DeleteWeakGlobalRefCallback(const jweak& object, void* state);
 
-        static void JSWrapperConstructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info);
-
         static bool IsJsRuntimeObject(const v8::Local<v8::Object>& object);
 
         jobject m_javaRuntimeObject;