Fix to issue nativephp/laravel #318 + General cleanup and DRYied Publish command #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rudeisnice
commented
May 31, 2024
•
Rudeisnice
commented
- fixes Building for Windows on arm64 Mac fails laravel#318
- Added user interaction if no input arguments are given in build and publish commands
- DRYied publish command so it runs build command with publish option
- native:build now has option to publish
- Serving now uses native php binary
|
Works fine on a fresh install of Windows 11 with Laravel Herd.
Crossbuilds from a Mac works fine too. |
Rudeisnice
changed the title
Rudeisnice
changed the title
Rudeisnice
commented
Jun 2, 2024
|
TODO:
|
simonhamp
reviewed
Jul 18, 2024
src/Commands/BuildCommand.php
Outdated
| } | ||
| $this->info((($publish ?? false) ? "Publishing" : 'Building') . " for {$os}"); | ||
|
|
||
| dd("npm run {$buildCommand}:{$os}"); |
There was a problem hiding this comment.
Did you meant to leave this dd in ?
There was a problem hiding this comment.
thats something I've missed. Probably because I was just checking for the right command, rather then building it and then forgot to remove it.
src/Commands/BuildCommand.php
Outdated
|
|
||
| protected $signature = 'native:build {os? : The operating system to build for (all, linux, mac, win)}'; | ||
| protected $availOs = ['win', 'linux', 'mac', 'all']; |
There was a problem hiding this comment.
Can we name this better than $availOs - prefer full words over abbreviations
There was a problem hiding this comment.
I've changed variable and function names accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.