Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel Reverb #27

Closed
wants to merge 2 commits into from
Closed

Laravel Reverb #27

wants to merge 2 commits into from

Conversation

simonhamp
Copy link
Member

@simonhamp simonhamp commented May 14, 2024

As laravel-websockets has been archived in favour of Laravel Reverb, we should look to support Reverb instead.

Fixes NativePHP/laravel#295

Checklist

  • Tested on Mac
  • Tested on Linux
  • Tested on Windows
  • Docs updated

@mr-ghomi
Copy link

On Windows 11, it works well before the build, but after the build, the software does not load

@JamesHemery
Copy link
Contributor

PHP binary need pcntl extension to use Reverb

@simonhamp
Copy link
Member Author

Thanks to this PR, there is now a cross-platform friendly approach that won't require websockets at all.

As Reverb uses pcntl under the hood, it will never see support on Windows, which leaves running a client-side websocket server in a weird state across NativePHP apps.

I'm in favour of ditching setting up a websocket server altogether here, as for the majority use-case, it's probably overkill.

So I'm going to close this PR and potentially spin up another that removes websockets altogether.

@simonhamp simonhamp closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websockets package doesn't support Laravel 11
3 participants