Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jexl parsing to disable some features which we aren't using t… #2299

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

jwomeara
Copy link
Collaborator

@jwomeara jwomeara commented Mar 8, 2024

…o improve parsing performance.

apmoriarty
apmoriarty previously approved these changes Mar 8, 2024
@FineAndDandy
Copy link
Collaborator

can you retarget this to version6.5?

@apmoriarty
Copy link
Collaborator

Could you update the following places that still use the default JexlFeatures?

  • EdgeQueryLogic line 350
  • PrintingVisitor line 196, 257
  • JexlAstHelper.parseQueryWithBackslashes

alerman
alerman previously approved these changes Mar 8, 2024
@jwomeara jwomeara dismissed stale reviews from alerman and apmoriarty via 3b71beb March 8, 2024 20:27
@jwomeara jwomeara changed the base branch from integration to release/version6.5 March 8, 2024 20:29
@jwomeara
Copy link
Collaborator Author

jwomeara commented Mar 8, 2024

can you retarget this to version6.5?

done

@jwomeara
Copy link
Collaborator Author

jwomeara commented Mar 8, 2024

Could you update the following places that still use the default JexlFeatures?

  • EdgeQueryLogic line 350
  • PrintingVisitor line 196, 257
  • JexlAstHelper.parseQueryWithBackslashes

done

Copy link
Collaborator

@FineAndDandy FineAndDandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking the time to clearly mark all features we are using

@hgklohr hgklohr merged commit a6569a3 into release/version6.5 Mar 11, 2024
3 checks passed
hgklohr added a commit that referenced this pull request Mar 11, 2024
#2299)

* Updated jexl parsing to disable some features which we aren't using to improve parsing performance.

* Updated to use custom configured JexlFeatures everywhere

---------

Co-authored-by: hgklohr <[email protected]>
hgklohr added a commit that referenced this pull request Mar 11, 2024
#2299)

* Updated jexl parsing to disable some features which we aren't using to improve parsing performance.

* Updated to use custom configured JexlFeatures everywhere

---------

Co-authored-by: hgklohr <[email protected]>
hgklohr added a commit that referenced this pull request Mar 11, 2024
#2299)

* Updated jexl parsing to disable some features which we aren't using to improve parsing performance.

* Updated to use custom configured JexlFeatures everywhere

---------

Co-authored-by: hgklohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants