Updated the ivarator mechanisms to cleanup directories #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschmidt10
reviewed
Feb 16, 2023
warehouse/query-core/src/main/java/datawave/query/iterator/ivarator/IvaratorCacheDirConfig.java
Outdated
Show resolved
Hide resolved
apmoriarty
reviewed
Mar 1, 2023
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/jexl/visitors/IteratorBuildingVisitor.java
Show resolved
Hide resolved
apmoriarty
previously approved these changes
Mar 10, 2023
ivakegg
force-pushed
the
feature/ivaratorCleanup
branch
from
a5226a9
to
a7cc823
Compare
drewfarris
reviewed
Mar 27, 2023
warehouse/query-core/src/main/java/datawave/query/iterator/builder/IvaratorBuilder.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/builder/IvaratorBuilder.java
Show resolved
Hide resolved
nonessentialprototype
previously approved these changes
Mar 29, 2023
ivakegg
commented
Mar 30, 2023
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Outdated
Show resolved
Hide resolved
jwomeara
requested changes
Apr 13, 2023
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/core/iterators/DatawaveFieldIndexCachingIteratorJexl.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/builder/IvaratorBuilder.java
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/ivarator/IvaratorCacheDirConfig.java
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/jexl/visitors/IteratorBuildingVisitor.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/jexl/visitors/IteratorBuildingVisitor.java
Outdated
Show resolved
Hide resolved
ivakegg
force-pushed
the
feature/ivaratorCleanup
branch
2 times, most recently
from
b5ee9eb
to
37f1be1
Compare
jwomeara
requested changes
Apr 22, 2023
warehouse/query-core/src/main/java/datawave/query/iterator/builder/IvaratorBuilder.java
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/builder/IvaratorBuilder.java
Outdated
Show resolved
Hide resolved
|
@ivakegg are you done making changes? i can't tell looking at your latest comments. |
I think I am. |
jwomeara
previously approved these changes
May 23, 2023
done. This has resulted in collapsing the directory structure. However since they are now deleted when done we should be able to avoid creating too many subdirectories. Co-authored-by: Whitney O'Meara <[email protected]>
ivakegg
force-pushed
the
feature/ivaratorCleanup
branch
from
42490a0
to
86c6444
Compare
Update tests.yml for int branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the ivarator mechanisms to cleanup directories when they are done. This has resulted in collapsing the directory structure. However since they are now deleted when done we should be able to avoid creating too many subdirectories.