Skip to content

Commit

Permalink
correct response title & resolve formatting issues
Browse files Browse the repository at this point in the history
  • Loading branch information
foster33 committed Sep 19, 2023
1 parent feb95a3 commit f424057
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,67 +13,67 @@
import java.util.TreeMap;

public class BaseQueryMetricSubplanResponse<T extends BaseQueryMetric> extends BaseResponse implements HtmlProvider {

private static final long serialVersionUID = 1L;
private static final String TITLE = "Query Metrics";
private static final String TITLE = "Query Subplans";
private static final String EMPTY = "";
@XmlElementWrapper(name = "queryMetrics")
@XmlElement(name = "queryMetric")
@XmlElementWrapper(name = "querySubplans")
@XmlElement(name = "querySubplan")
protected List<T> result = null;
@XmlElement
protected int numResults = 0;
@XmlTransient
private boolean administratorMode = false;
@XmlTransient
private boolean isGeoQuery = false;

private static String numToString(long number) {
return (number == -1 || number == 0) ? "" : Long.toString(number);
}

public List<T> getResult() {
return result;
}

public int getNumResults() {
return numResults;
}

public void setResult(List<T> result) {
this.result = result;
this.numResults = this.result.size();
}

public void setNumResults(int numResults) {
this.numResults = numResults;
}

public boolean isAdministratorMode() {
return administratorMode;
}

public void setAdministratorMode(boolean administratorMode) {
this.administratorMode = administratorMode;
}

public boolean isGeoQuery() {
return isGeoQuery;
}

public void setGeoQuery(boolean geoQuery) {
isGeoQuery = geoQuery;
}

@Override
public String getTitle() {
return TITLE;
}

@Override
public String getPageHeader() {
return getTitle();
}

@Override
public String getHeadContent() {
if (isGeoQuery) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,9 @@ enum DEFAULT_DATETIME {
*/
@Autowired
public QueryMetricOperations(@Named("queryMetricCacheManager") CacheManager cacheManager, ShardTableQueryMetricHandler handler,
QueryGeometryHandler geometryHandler, MarkingFunctions markingFunctions, BaseQueryMetricListResponseFactory queryMetricListResponseFactory, BaseQueryMetricSubplanResponseFactory queryMetricSubplanResponseFactory,
MergeLockLifecycleListener mergeLock, MetricUpdateEntryProcessorFactory entryProcessorFactory, QueryMetricOperationsStats stats) {
QueryGeometryHandler geometryHandler, MarkingFunctions markingFunctions, BaseQueryMetricListResponseFactory queryMetricListResponseFactory,
BaseQueryMetricSubplanResponseFactory queryMetricSubplanResponseFactory, MergeLockLifecycleListener mergeLock,
MetricUpdateEntryProcessorFactory entryProcessorFactory, QueryMetricOperationsStats stats) {
this.handler = handler;
this.geometryHandler = geometryHandler;
this.cacheManager = cacheManager;
Expand Down Expand Up @@ -257,7 +258,7 @@ private void storeMetricUpdate(QueryMetricUpdateHolder metricUpdate) {
}
storeTimer.stop();
}

List<BaseQueryMetric> getMetricList(String queryId, ProxiedUserDetails currentUser, String blacklistedFields) {
List<BaseQueryMetric> metricList = new ArrayList<>();
try {
Expand Down Expand Up @@ -300,7 +301,7 @@ List<BaseQueryMetric> getMetricList(String queryId, ProxiedUserDetails currentUs
}
return metricList;
}

/**
* Returns metrics for the current users queries that are identified by the id
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public QueryGeometryHandler geometryHandler(QueryMetricHandlerProperties queryMe
public BaseQueryMetricListResponseFactory queryMetricListResponseFactory() {
return new QueryMetricListResponseFactory();
}

@Bean
public BaseQueryMetricSubplanResponseFactory queryMetricSubplanResponseFactory() {
return new QueryMetricSubplanResponseFactory();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
import datawave.microservice.querymetric.BaseQueryMetricSubplanResponse;

public interface BaseQueryMetricSubplanResponseFactory<T extends BaseQueryMetricSubplanResponse> {

T createSubplanResponse();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
import datawave.microservice.querymetric.BaseQueryMetricSubplanResponse;

public class QueryMetricSubplanResponseFactory implements BaseQueryMetricSubplanResponseFactory {

@Override
public BaseQueryMetricSubplanResponse createSubplanResponse() {
return new BaseQueryMetricSubplanResponse();
}
}
}

0 comments on commit f424057

Please sign in to comment.