Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --trust-repo option to download CLI command #807

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

juhoinkinen
Copy link
Member

Downloading projects from Hugging Face Hub should be done from trusted sources only.

After this PR, if the repository hasn’t been used for downloads previously (i.e., it doesn’t appear in the Hugging Face Hub cache on local system), the --trust-repo option needs to be used.

@juhoinkinen juhoinkinen added this to the 1.2 milestone Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.

Project coverage is 99.55%. Comparing base (c923992) to head (caf0325).

Files with missing lines Patch % Lines
annif/hfh_util.py 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   99.64%   99.55%   -0.10%     
==========================================
  Files          93       93              
  Lines        7078     7130      +52     
==========================================
+ Hits         7053     7098      +45     
- Misses         25       32       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juhoinkinen juhoinkinen changed the base branch from main to devcontainer September 30, 2024 10:32
@juhoinkinen juhoinkinen changed the base branch from devcontainer to main September 30, 2024 10:32
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juhoinkinen juhoinkinen marked this pull request as ready for review September 30, 2024 11:00
Copy link

sonarcloud bot commented Sep 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants