[ApproximateNearestNeighbors] Add notebook and remove exactNearestNeighborsJoin API from the ann class #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N class Signed-off-by: Jinfeng <[email protected]>
eordentlich
reviewed
May 9, 2024
| "num_vecs = 100000\n", | ||
| "vec = np.random.randn(dim).reshape([1,dim])\n", | ||
| "arr = np.random.randn(num_vecs).reshape([num_vecs,1])\n", | ||
| "items = arr * vec\n", |
There was a problem hiding this comment.
We might want to have a 'better' selection of vectors. I see this is also in the exact knn notebook but didn't notice before. The vectors are all multiples of a single vectors. Perhaps we can find a better choice of vectors for the next release.
eordentlich
reviewed
May 9, 2024
| @@ -1323,4 +1331,4 @@ def approxSimilarityJoin( | |||
| where item_vector v1 is one of the k nearest neighbors of query_vector v2 and their distance is dist(v1, v2). | |||
| """ | |||
|
|
|||
| return self.exactNearestNeighborsJoin(query_df, distCol) | |||
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.