Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cuml from 23.06 to 23.08 in pytests and ci #353

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

lijinf2
Copy link
Collaborator

@lijinf2 lijinf2 commented Aug 7, 2023

Fixed an issue in LinearRegression that adds the copy_X init argument to match cuml 23.08 LinearRegression init argument list.

@lijinf2 lijinf2 changed the title upgrade cuml from 23.06 to 23.08 in pytests and ci [DRAFT] Upgrade cuml from 23.06 to 23.08 in pytests and ci Aug 7, 2023
@lijinf2
Copy link
Collaborator Author

lijinf2 commented Aug 7, 2023

build

1 similar comment
@lijinf2
Copy link
Collaborator Author

lijinf2 commented Aug 7, 2023

build

@lijinf2 lijinf2 marked this pull request as ready for review August 8, 2023 00:17
@lijinf2 lijinf2 changed the title [DRAFT] Upgrade cuml from 23.06 to 23.08 in pytests and ci Upgrade cuml from 23.06 to 23.08 in pytests and ci Aug 8, 2023
@lijinf2
Copy link
Collaborator Author

lijinf2 commented Aug 8, 2023

build

RUN conda install -y -c conda-forge mamba=1.4.9 libarchive && \
mamba install -y -c rapidsai -c nvidia -c conda-forge cuml=$CUML_VER python=3.9 cuda-toolkit=11.5 \
mamba install -y -c rapidsai-nightly -c nvidia -c conda-forge cuml=$CUML_VER python=3.9 cuda-toolkit=11.5 \
Copy link
Collaborator

@pxLi pxLi Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rapids now use cuda-version pkg (https://anaconda.org/conda-forge/cuda-version/files) instead of cuda-toolkit to navigate the specific libcudf pkg (these 2 pkgs have diverged about version patterning)
https://github.com/rapidsai/cudf#conda, could try use cuda-version=11.8

Copy link
Collaborator Author

@lijinf2 lijinf2 Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment! Cuml is still using cuda-toolkit in the release selector: https://docs.rapids.ai/install. Maybe we can stay with cuda-toolkit for now and try to use cuda-version after cuml adopts it.

Copy link
Collaborator

@pxLi pxLi Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think their page is out of date at least for 23.08 (not-released yet) rapidsai/cuml#5318 rapidsai/cudf#13615
but feel free to update it when needed

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Aug 8, 2023

build

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Aug 8, 2023

build

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Aug 8, 2023

Tested in rapids-23.06 locally. run_tests.sh passed.

@lijinf2 lijinf2 merged commit 983cdc2 into NVIDIA:branch-23.08 Aug 8, 2023
1 check passed
@lijinf2 lijinf2 deleted the test_nightly branch March 6, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants