Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gpu version crossvalidator for RandomForestRegressor #303

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Support gpu version crossvalidator for RandomForestRegressor #303

merged 2 commits into from
Jun 26, 2023

Conversation

wbo4958
Copy link
Collaborator

@wbo4958 wbo4958 commented Jun 21, 2023

No description provided.

@wbo4958
Copy link
Collaborator Author

wbo4958 commented Jun 21, 2023

build

eordentlich
eordentlich reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

python/src/spark_rapids_ml/regression.py Outdated

Returns
-------
float
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list of float?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Done

python/src/spark_rapids_ml/regression.py Outdated
input: TransformInputType,
transformed: TransformInputType,
) -> pd.DataFrame:
# calculate the count of (label, prediction)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count -> metrics

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Done

@wbo4958
Copy link
Collaborator Author

wbo4958 commented Jun 25, 2023

build

eordentlich
eordentlich approved these changes Jun 25, 2023
View reviewed changes
Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wbo4958 wbo4958 merged commit 8df31f1 into NVIDIA:branch-23.06 Jun 26, 2023
1 check passed
@wbo4958 wbo4958 deleted the rfr-trans-eval branch June 26, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eordentlich eordentlich eordentlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbo4958 @eordentlich