Bump github.com/NVIDIA/go-nvml from 0.12.0-3 to 0.12.0-4 #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/go_modules/main/github.com/NVIDIA/go-nvml-0.12.0-4
branch
from
64422a0
to
2717e78
Compare
Bumps [github.com/NVIDIA/go-nvml](https://github.com/NVIDIA/go-nvml) from 0.12.0-3 to 0.12.0-4. - [Commits](NVIDIA/go-nvml@v0.12.0-3...v0.12.0-4) --- updated-dependencies: - dependency-name: github.com/NVIDIA/go-nvml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/main/github.com/NVIDIA/go-nvml-0.12.0-4
branch
from
2717e78
to
5df9201
Compare
tariq1890
requested review from
elezar,
klueska and
cdesiniotis
and removed request for
elezar and
klueska
|
Looks like a breaking change was introduced to the new go-nvml lib. We should reconsider the semver bumps when we introduce interface changes IMO |
|
@tariq1890 the semver in the |
Signed-off-by: Evan Lezar <[email protected]>
This updates the following dependencies that also have transitive dependencies on the new go-nvlib and go-nvml versions: * github.com/NVIDIA/go-gpuallocator * github.com/NVIDIA/nvidia-container-toolkit Signed-off-by: Evan Lezar <[email protected]>
elezar
approved these changes
Apr 22, 2024
elezar
deleted the
dependabot/go_modules/main/github.com/NVIDIA/go-nvml-0.12.0-4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/NVIDIA/go-nvml from 0.12.0-3 to 0.12.0-4.
Commits
1fa43fdReplace Library interface with Extensions interfaced72aa68Add a mock DGXA100 server that implements parts of the NVML interface9a1711aAdd mocks for all interfaces under pkg/nvml/mock6f20742Add ability to generate interfaces and package methods from libraryb34e706Ensure that exported structs reference interface types not private typesf01937eFix API call for GetVgpuCompatibility3d3e863Convert all uppercase local variables to lowercase80b4064Convert GpmSample into an interface instead of a concrete type630d5a6Fix API call for GpmSampleAllocfbdfe74Convert ComputeInstance into an interface instead of a concrete typeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)