Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for falcon2 #1926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

puneeshkhanna
Copy link

No description provided.

@puneeshkhanna
Copy link
Author

@hchings hchings self-assigned this Sep 16, 2024
@hchings hchings added the triaged Issue has been triaged by maintainers label Sep 16, 2024
@hchings
Copy link
Collaborator

hchings commented Sep 16, 2024

Hi @puneeshkhanna, thanks for your contribution!

models/falcon/convert.py and models/falcon/config.py also need some changes as well for your code changes to work.
We've made the changes so no action needed from your end. We'll close this out once things are fully tested.

@MartinMarciniszyn
Copy link
Collaborator

@lfr-0531, could you review this pull request please?

@jaedeok-nvidia
Copy link

Hi @MartinMarciniszyn, @hchings is currently working on this PR, and I have reviewed it. We discovered that some adjustments are needed. For example, falcon2 uses rotary_base=50042 which is not addressed in this PR. Additionally, there is an unclear issue that we are actively working on resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been triaged by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants