Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rex Regridder port #228

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Use rex Regridder port #228

merged 5 commits into from
Jul 29, 2024

Conversation

ppinchuk
Copy link
Collaborator

Regridder was ported to rex, so this PR deprecates the implementation in sup3r in favor of rex.

Thanks for sharing this functionality! :)

@ppinchuk ppinchuk added the enhancement New feature or request label Jul 29, 2024
@ppinchuk ppinchuk requested a review from bnb32 July 29, 2024 17:50
@ppinchuk ppinchuk self-assigned this Jul 29, 2024
bnb32
bnb32 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@bnb32 bnb32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code removed is good in my book! Thanks for moving this over.

@ppinchuk ppinchuk merged commit c72c817 into bnb/dh_refactor Jul 29, 2024
5 of 10 checks passed
@ppinchuk ppinchuk deleted the pp/rex_regridder branch July 29, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnb32 bnb32 bnb32 approved these changes

Assignees

@ppinchuk ppinchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppinchuk @bnb32