Fix component-is-attached-to-system check #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-thom
commented
Mar 19, 2024
| _services = isnothing(services) ? [] : services | ||
| return System(base_power, buses, generators, loads, _services; kwargs...) | ||
| _branches = isnothing(branches) ? [] : branches |
There was a problem hiding this comment.
Apparently, the demo constructor never added branches or services...
daniel-thom
commented
Mar 19, 2024
| return !isnothing(get_component(T, sys, name)) | ||
| existing_component = get_component(T, sys, get_name(component)) | ||
| isnothing(existing_component) && return false | ||
| return component === existing_component |
There was a problem hiding this comment.
This is the fix.
jd-lara
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1016. The check for whether a component is attached to a system was inadequate. It checked whether a component of the given type and name was attached to the system. If you built two systems with the same components and names, that check would incorrectly pass. This PR fixes that bug.
There were numerous tests that only passed because of this same-type-and-name comparison. This PR also fixes those tests.