Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current lims to psy3 #1014

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Add current lims to psy3 #1014

merged 6 commits into from
Sep 12, 2023

Conversation

rodrigomha
Copy link
Contributor

Currently is not working. I think is related to having an abstract type in the limiter field of the DynamicInverter struct.

@@ -195,6 +195,11 @@ export VoltageModeControl
export CurrentModeControl
export RECurrentControlB

# InverterLimiters Export
export MagnitudeCurrentLimiter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We missing the circle one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnitude is circle, Instantaneous is Square, based on this paper: https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9973369

We can change the name to circular, and square

@jd-lara jd-lara marked this pull request as ready for review September 12, 2023 00:24
@jd-lara jd-lara changed the base branch from psy3 to main September 12, 2023 00:24
@jd-lara jd-lara self-requested a review September 12, 2023 00:35
@jd-lara jd-lara merged commit 3fff8dc into main Sep 12, 2023
4 of 8 checks passed
@jd-lara jd-lara deleted the rh/add_currentlims_to_psy3 branch September 12, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants