Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved issues causing warnings #430

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

MOshima-PIFSC
Copy link
Contributor

What is the feature?

  • changed int to size_t in population.hpp and FIMS.cpp
  • updated constructor in data_object.hpp
  • changed size_t to int in rcpp.population

How have you implemented the solution?

Does the PR impact any other area of the project?

How to test this change

Run devtools::load_all() to verify there are no compiler warnings.

Developer pre-PR checklist

  • I relied on GitHub actions to 🧪 things for me while I sat on the 🛋️.

@MOshima-PIFSC MOshima-PIFSC linked an issue Aug 2, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@Bai-Li-NOAA Bai-Li-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for getting rid of the warnings.

Do we need to add a GHA workflow (not in this pull request) and run devtools::load_all()? The GHA workflow will fail if there are warnings in the output. I am thinking about something like this:

output <- utils::capture.output(devtools::load_all())
base::grep("warning", output, value = TRUE)

@Andrea-Havron-NOAA Andrea-Havron-NOAA merged commit d5db2c5 into main Aug 8, 2023
9 checks passed
@Andrea-Havron-NOAA Andrea-Havron-NOAA deleted the 351-bug-resolve-c++-compile-warnings branch August 8, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Resolve C++ compile warnings
3 participants