Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format C++ code with clang format #421

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

ChristineStawitz-NOAA
Copy link
Contributor

@Andrea-Havron-NOAA Andrea-Havron-NOAA requested review from a team and jimianelli and removed request for a team July 17, 2023 23:04
@Rick-Methot-NOAA
Copy link

Note that the SS3 project has a tool to format code. Perhaps you have already used it in developing this code.

@Andrea-Havron-NOAA Andrea-Havron-NOAA removed the request for review from jimianelli July 17, 2023 23:12
@k-doering-NOAA
Copy link
Member

Note that the SS3 project has a tool to format code. Perhaps you have already used it in developing this code.

@Rick-Methot-NOAA yes, it is the same tool. For FIMS, it actually is run with every change to the cpp source code thanks to GitHub actions (and the fact that we are using pure c++ instead of an admb tpl file)

@Andrea-Havron-NOAA Andrea-Havron-NOAA merged commit 25a2405 into main Jul 18, 2023
9 checks passed
@Andrea-Havron-NOAA Andrea-Havron-NOAA deleted the format-c++-code branch July 18, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants