Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPINEDEM-3725 AC2 #1046

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SPINEDEM-3725 AC2 #1046

wants to merge 5 commits into from

Conversation

j-perry2
Copy link
Contributor

Summary

  • Routine Change

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.

@github-actions GitHub Actions
Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3725

davidhamill1-nhs
davidhamill1-nhs approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@davidhamill1-nhs davidhamill1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to figure out why the pipelines are not running.

guyflavell2-nhs
guyflavell2-nhs reviewed Sep 11, 2024
View reviewed changes
specification/personal-demographics.yaml

Special care should be taken when performing multiple removals in the same list; as removing a particular index could affect all subsequent index positions. The next two examples perform **<u>exactly</u>** the same operation.
Special care should also be taken when performing multiple removals in the same list; as removing a particular index could affect all subsequent index positions. The next two examples perform **<u>exactly</u>** the same operation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a recommendation here to perform updates to a list in reverse order to avoid this complication?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit further down this section it has such a recommendation:

personal-demographics-service-api/specification/personal-demographics.yaml

Line 1082 in 8168674

Which is the intended outcome. Providing the patches with the indexes descending means that the list stays in a stable format the whole way through as the only changes to the index positions are items have been passed over already.

@github-actions GitHub Actions
Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhamill1-nhs davidhamill1-nhs davidhamill1-nhs approved these changes

@guyflavell2-nhs guyflavell2-nhs guyflavell2-nhs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-perry2 @davidhamill1-nhs @guyflavell2-nhs