Update smoke pack to not include app restricted tests #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: SPINEDEM-3420 |
|
This branch is working on a ticket to deploy to internal-portal. Here's a handy link to the specification: feature/SPINEDEM-3420-smoke-test-fix specification |
| @@ -24,6 +24,7 @@ Background: | |||
| * url baseURL | |||
|
|
|||
|
|
|||
| @smoke | |||
There was a problem hiding this comment.
Does this patient exist in INT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The smoke tests against int were failing because of an issue with the JWT token encoding. This may well have been because there's no JWT token available. The pytest smoke test pack didn't include any app restricted tests so never ran the JWT authentication routine.
This PR removes the app restricted test from the new smoke pack, and this hopefully means the smoke tests will run in the int environment.