feat: add mesh retrival function #26
Conversation
|
Can you rename the PR title to follow the naming convention, please |
millsotron-ibm
changed the title
src/BSSelectIntegrationService/RetrieveMeshFile/RetrieveMeshFile.csproj
Outdated
Show resolved
Hide resolved
src/MeshIntegrationService/RetrieveMeshFile/RetrieveMeshFile.cs
Outdated
Show resolved
Hide resolved
src/MeshIntegrationService/RetrieveMeshFile/RetrieveMeshFile.cs
Outdated
Show resolved
Hide resolved
src/MeshIntegrationService/RetrieveMeshFile/RetrieveMeshFile.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Can you rename this file to IBlobStorageHelper.cs, please
tests/BSSelectIntegrationServiceTests/retrieveMeshFileTest/MeshResponseTestHelper.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Can you rename the folders to tests/MeshIntegrationServiceTests/RetrieveMeshFileTests/
There was a problem hiding this comment.
Still need to rename the retrieveMeshFileTest folder to RetrieveMeshFileTests
tests/BSSelectIntegrationServiceTests/retrieveMeshFileTest/RetrieveMeshFileTest.cs
Outdated
Show resolved
Hide resolved
millsotron-ibm
force-pushed
the
feat/DTOSS-4076/MeshRetrivalFunction
branch
from
b068dfd
to
94d51b1
Compare
| } | ||
| /// <summary> | ||
| /// This function polls the MESH Mailbox every 5 minutes, if there is a file posted to the mailbox. | ||
| /// If there is a file in there will move the file to the Service Insights Blob Storage where it will be picked up by the ReceiveCaasFile Function. |
There was a problem hiding this comment.
ReceiveCaasFile is from Cohort Manager
| using Microsoft.Extensions.Logging; | ||
| using NHS.MESH.Client.Models; | ||
|
|
||
| namespace NHS.Screening.RetrieveMeshFile; |
There was a problem hiding this comment.
Namespace should be NHS.ServiceInsights.MeshIntegrationService
| "FUNCTIONS_WORKER_RUNTIME": "dotnet-isolated", | ||
| "MeshApiBaseUrl" : "http://localhost:8700/messageexchange", | ||
| "BSSMailBox": "X26ABC1", | ||
| "bssfolder_STORAGE":"UseDevelopmentStorage=true", |
There was a problem hiding this comment.
Can we use the AzureWebJobsStorage environment variable instead of creating an additional variable with the same value?
| "MeshApiBaseUrl" : "http://localhost:8700/messageexchange", | ||
| "BSSMailBox": "X26ABC1", | ||
| "bssfolder_STORAGE":"UseDevelopmentStorage=true", | ||
| "bsscontainer_NAME": "sample-container", |
There was a problem hiding this comment.
For consistency can you use PascalCase here
There was a problem hiding this comment.
Still need to rename the retrieveMeshFileTest folder to RetrieveMeshFileTests
There was a problem hiding this comment.
Rename file to RetrieveMeshFileTests, please
| using NHS.ServiceInsights.Model; | ||
| using NHS.ServiceInsights.Tests.BSSelectIntegrationTests; | ||
|
|
||
| namespace NHS.Screening.RetrieveMeshFile; |
There was a problem hiding this comment.
Namespace should be NHS.ServiceInsights.MeshIntegrationServiceTests
|
|
||
| namespace NHS.Screening.RetrieveMeshFile; | ||
| [TestClass] | ||
| public class RetrieveMeshFileTest |
There was a problem hiding this comment.
Rename class to RetrieveMeshFileTests, please
Description
Add scheduled ReceiveMeshMailbox Function to get payload from mesh mailbox and send to the azurite blob sample-container.
Added associated shared functions to support the ReceiveMeshMailbox function.
Added unit tests for the ReceiveMeshMailbox function.
Updated CICD pipelines to include dependencies for mesh mailbox client in build and test.
Context
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-4076
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.