Feature/hakh11 nrl 1002 consumer integration tests #710
Conversation
hamzakhan24-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
|
🚀 PR environment successfully deployed. |
hamzakhan24-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
hamzakhan24-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
| When consumer 'RX898' searches for DocumentReferences with parameters: | ||
| | parameter | value | | ||
| | subject | 9278693472 | | ||
| | custodian | 02V | |
There was a problem hiding this comment.
As far as I can tell, tests a search using both NHS# + custodian filters. If there is only one pointer and it has a matching NHS# + custodian, in theory the scenario would pass even if either the subject filter or the custodian filter were not working. It might be good to additionally set up a few that we would expect to be filtered out: one with matching custodian but wrong NHS number, and vice versa.
There was a problem hiding this comment.
have added two new scenarios which isolate each filter:
Search for a DocumentReference by NHS Number and Custodian where NHS number filter matches one pointer from result set
Search for a DocumentReference by NHS Number and Custodian where Custodian filter matches one pointer from result set
| | http://snomed.info/sct | 861421000000109 | | ||
| And a DocumentReference resource exists with values: | ||
| | property | value | | ||
| | id | DK94-111-DeleteDocRefTest1 | |
There was a problem hiding this comment.
is this a deletion test, if so does it belong in the delete feature? I see that it searches after the deletion so it's more of a combined scenario, this could be reflected in the scenario title if it lives here (it's slightly more complex than simply searching by NHS number where there never were any pointers for that patient)
There was a problem hiding this comment.
Perhaps the deletion is not required, but the main goal of this test is to setup an NHS number which has 0 pointers, so I figured one way to do that is to create a pointer for an NHS number and then delete that pointer. May not be necessary.
| --define="env=$(TF_WORKSPACE_NAME)" \ | ||
| --define="account_name=$(ENV)" \ | ||
| --define="use_shared_resources=${USE_SHARED_RESOURCES}" \ | ||
| $(FEATURE_TEST_ARGS) |
There was a problem hiding this comment.
! this seems very handy, could you add a line to the readme specifying this option alongside where it mentions the full integration test run?
There was a problem hiding this comment.
Readme now updated 👍
hamzakhan24-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
|
🚀 PR environment successfully deployed. |
hamzakhan24-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
hamzakhan24-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
|
hamzakhan24-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
|
🚀 PR environment successfully deployed. |
hamzakhan24-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
-Refactored and added scenarios to two feature files:
SearchPostDocumentReference-success
SearchDocumentReference-success
-Added "custom tag" MakeFile command to enable selective scenario runs