Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Don't ask again" User Experience improvements across DevHub #691

Merged
merged 29 commits into from
Mar 21, 2024

Conversation

petersalomonsen
Copy link
Collaborator

@petersalomonsen petersalomonsen commented Mar 14, 2024

Similar to #687, but for whole DevHub.

What is covered here is improving of the "Don't ask again experience for":

  • Creating a discussion
    • Notice the new SubscribedFeed.jsx component ( a copy of the original feed component ), which use the subscription parameter for receiving the feed index contents. This will automatically refresh every 5 seconds. (see notes over the video below about this)
  • Submitting a proposal draft

This PR also reduce flaky tests by

  • partly by using alternative RPC providers in some cases
    • Lava for fetching widgets
    • 1rpc for archive transactions
  • ensuring await before expects, increasing test timeouts
  • remove some expectations that are difficult to catch since it happens so fast ( which is the case for the loading spinner after the transaction has completed, it could still be there for a second or two in some cases, but it's hard for the test to expect this ).

Preview environment

https://near.social/devgovgigs.petersalomonsen.near/widget/app

Videos and issues

The video below shows the user experience when creating a discussion. Note the delay between that the spinner disappears and the discussion appear. The challenge here is that there is that Social.index cache invalidation is hard (haven't found a way yet) to trigger, and so I've configured the feed to subscribe every fifth second. The ignoreCache option of Social.index does unfortunately only work once per page session ( needs a reload ).

creatediscussion.mp4

Proposals:

proposal.mp4

Part of issue #689

@petersalomonsen petersalomonsen changed the title test setup for discussions "Don't ask again" User Experience improvements across DevHUB Mar 14, 2024
@petersalomonsen petersalomonsen changed the title "Don't ask again" User Experience improvements across DevHUB "Don't ask again" User Experience improvements across DevHub Mar 14, 2024
@petersalomonsen petersalomonsen marked this pull request as ready for review March 21, 2024 06:29
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @petersalomonsen for adding the tests for proposals.

playwright-tests/tests/community.spec.js Show resolved Hide resolved
playwright-tests/tests/discussions.spec.js Show resolved Hide resolved
playwright-tests/tests/funding.spec.js Show resolved Hide resolved
@Megha-Dev-19 Megha-Dev-19 merged commit 4f40f08 into main Mar 21, 2024
2 checks passed
@Megha-Dev-19 Megha-Dev-19 deleted the feat/689-dont-ask-again-ux branch March 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants