Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 237, ensure ancestry plot only uses project QC, standardizing plots in QC report #273

Closed
wants to merge 3 commits into from
Closed

Issue 237, ensure ancestry plot only uses project QC, standardizing plots in QC report #273

wants to merge 3 commits into from

Conversation

kliao12
Copy link
Collaborator

@kliao12 kliao12 commented Apr 12, 2024

  • Updated triangle ancestry plot to include unknowns and QC. Updated to subject-level to ensure QC are project QC rather than internal QC. Ensure cases are plotted on top for max visibility
  • Standardized colors across plots by creating dictionary mapping labels (case, control, QC, unknown) to specific colors (chosen to ensure colorblind friendly)
  • Removed unused plot_ancestry_grafpop.py script
  • In plot autosomal heterozygosity script, updated plot title from "Homozygosity F Coefficient" to "Heterozygosity F Coefficient" per more common use decided by Jia/Jiahui

Fixes #237

@kliao12 kliao12 linked an issue Apr 12, 2024 that may be closed by this pull request
Unknow samples missing in the triangle plot (Figure 3) #237
Closed
@kliao12 kliao12 closed this Apr 12, 2024
@kliao12 kliao12 reopened this Apr 12, 2024
@kliao12 kliao12 closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknow samples missing in the triangle plot (Figure 3)
1 participant
@kliao12