Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect parameter name in cqmusic #2536

Closed
wants to merge 1 commit into from

Conversation

Fripine
Copy link

@Fripine Fripine commented Sep 7, 2024

https://docs.go-cqhttp.org/cqcode/#%E9%9F%B3%E4%B9%90%E8%87%AA%E5%AE%9A%E4%B9%89%E5%88%86%E4%BA%AB

还有修改的这个地方上面不远处,那个subType的判断逻辑也很奇怪,先判断是否存在subType,而文档中却没有对subType字段的注释。而且subType字段如果丢失,返回的是ServiceElement (xml消息),构造xml消息不对subType进行判断,默认就是qqmusic。这一段属实给我看绕晕了,按照我自己的想法,如果用户不填写subType,应当返回的是携带默认subType为 qqmusic的MusicShareElement,而xml应当摘出去。

不好意思,以前用gocq的时候没试过发xml消息,这边逻辑确实看的有些懵

@Fripine Fripine closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant