Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated group policy docs and picture of File Explorer page #5051

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

acekirkpatrick
Copy link
Contributor

@acekirkpatrick acekirkpatrick commented Jul 4, 2024

This is for the group policy changes in PowerToys #33475.
I also updated the screenshot for File Explorer to show the new toggle switch.

Please don't merge before:

Copy link
Contributor

@acekirkpatrick : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit f1b957c:

✅ Validation status: passed

File Status Preview URL Details
hub/images/powertoys-settings-fileexplorer.png ✅Succeeded
hub/powertoys/grouppolicy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Image File This PR added or updated an image file(s).

Copy link
Contributor

Learn Build status updates of commit 99b32c0:

✅ Validation status: passed

File Status Preview URL Details
hub/images/powertoys-settings-fileexplorer.png ✅Succeeded
hub/powertoys/grouppolicy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Image File This PR added or updated an image file(s).

Copy link
Contributor

Learn Build status updates of commit 3cadc35:

✅ Validation status: passed

File Status Preview URL Details
hub/images/powertoys-settings-fileexplorer.png ✅Succeeded
hub/powertoys/grouppolicy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Image File This PR added or updated an image file(s).

Copy link
Contributor

@alvinashcraft alvinashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We'll hold it until the release goes live. Thanks!

@htcfreek
Copy link
Contributor

The new image cuts off the Thumbnail Preview part of the settings page. For a good overview about the module we should not do this. @acekirkpatrick can you update the new image?

Copy link
Contributor

Learn Build status updates of commit 0de0c3b:

✅ Validation status: passed

File Status Preview URL Details
hub/images/powertoys-settings-fileexplorer.png ✅Succeeded
hub/powertoys/grouppolicy.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Image File This PR added or updated an image file(s).

Copy link
Contributor

@alvinashcraft alvinashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the screenshot to include the entire screen!

@alvinashcraft alvinashcraft merged commit f5a065e into MicrosoftDocs:docs Jul 30, 2024
2 checks passed
@htcfreek
Copy link
Contributor

@alvinashcraft
Can you plz revert this commit. The feature/changes were not merged for the 0.83.0 release. They will be in the 0.84.0 release in August/September.

@alvinashcraft
Copy link
Contributor

@alvinashcraft Can you plz revert this commit. The feature/changes were not merged for the 0.83.0 release. They will be in the 0.84.0 release in August/September.

Will do. On it now.

@alvinashcraft
Copy link
Contributor

@htcfreek Revert PR merged in private repo. It should sync to the public repo and live site in a few minutes. Thanks for the heads-up.

learn-build-service-prod bot pushed a commit that referenced this pull request Jul 30, 2024
This reverts commit f5a065e, reversing
changes made to 7330885.
learn-build-service-prod bot pushed a commit that referenced this pull request Jul 30, 2024
…-group-policy-file-explorer-pr5051

Revert "Merge pull request #5051 from acekirkpatrick/FileExplorer"
@htcfreek
Copy link
Contributor

Do we need a new PR from @acekirkpatrick to update the docs if it is implemented in PowerToys then?

@alvinashcraft
Copy link
Contributor

Yes, we'll need another PR to re-commit the changes in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants