fix: handle reserved words in table names #232
Draft
+95
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnadolny13
changed the title
…target-snowflake into reserved_table_name
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…target-snowflake into reserved_table_name
for more information, see https://pre-commit.ci
|
@edgarrmondragon see my recent changes. They solve the bug but not in a very elegant way, I was just hacking in fixes as I was running the tests so its not very well thought out, I'll probably refactor to clean it up. The gist is that instead of using conform_name to add quotes consistently in one place, since it had negative side effects, I send the full table name through the quote function for any case that we're building SQL string manually. The tests pass but I do worry that theres SDK string SQL building flows that I'm missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230
Adds failing test for: