Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create id.csv #919

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Create id.csv #919

merged 2 commits into from
Aug 3, 2024

Conversation

williamsp
Copy link
Contributor

Add Indonesian (bahasa Indonesia) translation file

@JeromeMartinez
Copy link
Member

Thank you for your translation proposal.

I adapted a bit the result for coherence with other files, please review the changes and squash the commits in 1 commit (else I'll do it but you will lose the GitHub "verified" tag).

@williamsp
Copy link
Contributor Author

williamsp commented Aug 3, 2024

Hi, thank you for sorting the file and add untranslated strings to the file. The changes you made looks good to me.
But on my last commit 148656b, I already translate the strings you have added before.
So, please review, and update the carriage return, ZZ_Automatic_Percent, ZZ_AutomaticLanguage_Percent, if necessary.
Thank you.

@JeromeMartinez
Copy link
Member

I squashed all in one commit, FYI if you target 100% (not mandatory) remaining lines are:
ComplementaryObject
HomeTheaterAvr
Lines_MaxCountPerEvent
Position_Cartesian
Position_Polar
RealtimeLoudnessCorrected

Pull then force push (all in one commit in case you update the patch) if you wish to add the "verified" flag to your commit on GitHub.

@williamsp
Copy link
Contributor Author

Ah, I missed those lines. But, all of them already translated now.
For the squash and force push, I cannot find them in Github Web, so I try it from console instead. But I'm not sure if I try the right command. Please advise. Thank you.

@JeromeMartinez
Copy link
Member

For the squash and force push, I cannot find them in Github Web, so I try it from console instead. But I'm not sure if I try the right command. Please advise. Thank you.

I don't use the "verified" stuff, here I see that the commit is unique and you are the only one assigned (when I pushed it was with both you and me) but still lacking the "verified" flag which was present in the past. Not a big deal.
I'll add another commit with the automatic stuff then merge.

@williamsp
Copy link
Contributor Author

Ah, I see. I think it's fine if just the verified flag that is missing.

@JeromeMartinez JeromeMartinez merged commit dfb4eec into MediaArea:master Aug 3, 2024
3 checks passed
@williamsp williamsp deleted the patch-1 branch August 4, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants