Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7407 return types for definitions #653

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

MAT-7407 return types for definitions #653

wants to merge 5 commits into from

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Oct 3, 2024

MADiE PR

Jira Ticket: MAT-7407
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@adongare adongare marked this pull request as ready for review October 3, 2024 17:17
@adongare adongare requested a review from a team as a code owner October 3, 2024 17:17
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (70adadd) to head (ab18bd8).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/components/editMeasure/editor/MeasureEditor.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #653      +/-   ##
===========================================
- Coverage    84.98%   84.96%   -0.02%     
===========================================
  Files           96       96              
  Lines         3862     3864       +2     
  Branches       819      819              
===========================================
+ Hits          3282     3283       +1     
- Misses         378      379       +1     
  Partials       202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant