Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7406/editDefinition #649

Merged
merged 6 commits into from
Sep 27, 2024
Merged

MAT-7406/editDefinition #649

merged 6 commits into from
Sep 27, 2024

Conversation

sb-prateekkeerthi
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-7406
(Optional) Related Tickets:

Summary

edit definition in cql builder from saved definition page

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-prateekkeerthi sb-prateekkeerthi requested a review from a team as a code owner September 25, 2024 15:19
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@9ba5ac9). Learn more about missing BASE report.
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/components/editMeasure/editor/MeasureEditor.tsx 12.50% 7 Missing ⚠️
...components/editMeasure/editor/DefinitionApplier.ts 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #649   +/-   ##
==========================================
  Coverage           ?   84.93%           
==========================================
  Files              ?       96           
  Lines              ?     3850           
  Branches           ?      819           
==========================================
  Hits               ?     3270           
  Misses             ?      378           
  Partials           ?      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sb-prateekkeerthi sb-prateekkeerthi merged commit 7990364 into develop Sep 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants