Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.32 #273

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Release 1.2.32 #273

merged 4 commits into from
Sep 16, 2024

Conversation

RohitKandimalla
Copy link
Contributor

@RohitKandimalla RohitKandimalla commented Sep 16, 2024

MADiE PR

Jira Ticket: MAT-6951
(Optional) Related Tickets:

Summary

  1. Migrating Storybook from v6 to v8
  2. Updating Material UI from v5 to v6
  3. Updated other dependencies that has vulnerabilities, had to replace few libraries as they are not maintained anymore (especially babel transform plugins for both react project and storybook)

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@RohitKandimalla RohitKandimalla self-assigned this Sep 16, 2024
@RohitKandimalla RohitKandimalla requested a review from a team as a code owner September 16, 2024 14:59
@RohitKandimalla RohitKandimalla changed the title Updated Storybook from v6 to v8, Used migration script for the most part Updated Storybook from v6 to v8 Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (b34469c) to head (9ddcec3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files          34       34           
  Lines         597      597           
  Branches      218      221    +3     
=======================================
  Hits          564      564           
  Misses         32       32           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RohitKandimalla RohitKandimalla changed the title Updated Storybook from v6 to v8 Release 1.2.32 Sep 16, 2024
Copy link
Contributor

@mcmcphillips mcmcphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me.
I'm unsure if the plugin change from umd to transform-class-properties will have issues in consuming applications imports though

@RohitKandimalla
Copy link
Contributor Author

RohitKandimalla commented Sep 16, 2024

I think this looks good to me. I'm unsure if the plugin change from umd to transform-class-properties will have issues in consuming applications imports though
umd transform plugin is updated with its latest equivalent plugin @babel/plugin-transform-modules-umd and similarly "transform-class-properties" is replaced with @babel/plugin-transform-class-properties

@RohitKandimalla RohitKandimalla merged commit a3b9334 into main Sep 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants