Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAT-7639] Remove extraneous label on DateTimeField Component #269

Merged

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Sep 5, 2024

MADiE PR

Jira Ticket: MAT-7639
(Optional) Related Tickets:

Summary

Remove extra label from DateTimeField.
Update styling to ensure consistent field height with other inputs.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner September 5, 2024 19:28
@jkotanchik-SB jkotanchik-SB self-assigned this Sep 5, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7639-remove-extraneous-label-on-datetimefield branch from 5f86c8e to 44bcaa9 Compare September 5, 2024 19:40
adongare
adongare previously approved these changes Sep 5, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7639-remove-extraneous-label-on-datetimefield branch from 44bcaa9 to 167a2ac Compare September 6, 2024 13:47
Instead, pass through the label content to the supplied TextField which already has a label prop.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7639-remove-extraneous-label-on-datetimefield branch from 167a2ac to eaec2e6 Compare September 6, 2024 13:50
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (c660f7b) to head (eaec2e6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   94.53%   94.36%   -0.18%     
==========================================
  Files          34       34              
  Lines         586      586              
  Branches      210      210              
==========================================
- Hits          554      553       -1     
- Misses         31       32       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkotanchik-SB jkotanchik-SB merged commit e9070d5 into main Sep 6, 2024
6 of 7 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7639-remove-extraneous-label-on-datetimefield branch September 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants