Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added extra params for mutiselect #183

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

sb-prateekkeerthi
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-5963
(Optional) Related Tickets:

Summary

added extra params for mutiselect to know if the value is added or deleted

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-prateekkeerthi sb-prateekkeerthi requested a review from a team as a code owner September 1, 2023 19:24
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #183 (f6f9f7e) into main (c4e9dd2) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   94.05%   94.04%   -0.02%     
==========================================
  Files          31       31              
  Lines         404      403       -1     
  Branches      101      101              
==========================================
- Hits          380      379       -1     
  Misses         12       12              
  Partials       12       12              
Files Changed Coverage Δ
react/components/DateTimeField/DateTimeField.jsx 80.00% <ø> (-3.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c4e9dd2) 325 314 96.62%
Head commit (f6f9f7e) 324 (-1) 313 (-1) 96.61% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#183) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@sb-prateekkeerthi sb-prateekkeerthi merged commit 766ebb6 into main Sep 1, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants