Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapter: synthesize and apply side effects (aka. controller commands) from catalog changes #29673

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

adapter: synthesize and apply side effects (aka. controller commands) from catalog changes #29673

wants to merge 5 commits into from

Commits on Sep 19, 2024

  1. adapter: synthesize and apply side effects (aka. controller commands)… 

    … from catalog changes

First step towards MaterializeInc#29279

With this we only wire up the new side-effects logic for
creating/dropping tables.
    @aljoscha
    aljoscha committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9eccb5e View commit details
    Browse the repository at this point in the history

  2. adapter: thread an ExecuteContext through to controller_apply_side_ef… 

    …fects
    @aljoscha
    aljoscha committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3f6edbb View commit details
    Browse the repository at this point in the history

  3. WIP: use side effects for all drops

    @aljoscha
    aljoscha committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b373e05 View commit details
    Browse the repository at this point in the history

  4. adapter: make controller_apply independent of Catalog state 

    In-memory catalog state will already have changed when we apply side
effects. So we need to derive any information that we need when applying
before. That is when generating the side effects.
    @aljoscha
    aljoscha committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bba4707 View commit details
    Browse the repository at this point in the history

  5. fixup! make assert more helpful

    @aljoscha
    aljoscha committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    53dc4ae View commit details
    Browse the repository at this point in the history