Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mz_internal.mz_kafka_source_tables introspection table for kafka source tables #29608

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented Sep 17, 2024

Motivation

Part of the work in #29373

This change is also detailed in the design doc: https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/20240625_source_versioning__table_from_sources.md#system-catalog--introspection-updates

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@rjobanp rjobanp force-pushed the kafka-source-tables branch 3 times, most recently from 55c911e to f6d3069 Compare September 18, 2024 15:54
@rjobanp rjobanp marked this pull request as ready for review September 18, 2024 17:19
@rjobanp rjobanp requested review from a team as code owners September 18, 2024 17:19
Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from docs side mod couple of nits (feel free to ignore)

doc/user/content/sql/system-catalog/mz_internal.md Outdated Show resolved Hide resolved
doc/user/content/sql/system-catalog/mz_internal.md Outdated Show resolved Hide resolved
@rjobanp rjobanp merged commit 177fd19 into MaterializeInc:main Sep 19, 2024
85 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants